Bump to 1.9.1; single-source version; force version from release tag …#5
Open
Robbie1977 wants to merge 1 commit into
Open
Bump to 1.9.1; single-source version; force version from release tag …#5Robbie1977 wants to merge 1 commit into
Robbie1977 wants to merge 1 commit into
Conversation
…in Docker build - package.json 1.8.1 -> 1.9.1; server.json 1.5.0 -> 1.9.1 (was stale). - src/index.ts: VERSION is now imported from package.json (was a hardcoded '1.8.1' that drifted from package.json and server.json — the cause of the wrong reported version). - docker.yml: add a 'Set version from release tag' step (on refs/tags/v*) that forces package.json + server.json to the tag before the image build, so the deployed server reports the released version. Mirrors publish-mcp.yml.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the reported version (preview showed
1.8.1after the #4 release) and stops it drifting again.Root cause
The version lived in three places that had drifted apart:
src/index.ts— hardcodedconst VERSION = '1.8.1'(what the server reports)package.json—1.8.1server.json—1.5.0(stale)#4shipped without bumping any of them.Changes
package.jsonandserver.json(was 1.5.0).src/index.ts:VERSIONis now imported frompackage.json(resolveJsonModuleis on; realtscemit + runtimerequire('../package.json')verified), so there's a single source of truth.docker.yml: new Set version from release tag step (refs/tags/v*) that forcespackage.json+server.jsonto the tag before the image build — so the deployed server reports the released version. Mirrors the existing step inpublish-mcp.yml(which already setsserver.jsonfor the registry).Effect
main/branch builds: reports the committed version (now 1.9.1).v*release tag:package.json/server.json/reportedVERSIONare all forced to the tag automatically — no more manual three-place edits.tsc
--noEmitclean;docker.ymlYAML valid.