Release v3.3.1 — surface uncounted (count -1) term-info queries#5
Merged
Conversation
get_term_info returns count -1 for query types it did not pre-count (common for
large ones like ImagesNeurons on a big region such as the medulla). The digest
filter treated that as "no data" and dropped the query, so the assistant was
told VFB holds nothing and answered "VFB does not currently hold data on the
number of images of neurons with a part in the medulla" — when VFB actually has
226,524.
count -1 means the data exists but was not counted; it must be RUN to get the
result. Keep such queries in the digest and render them as an explicit
instruction ("run this query — call vfb_run_query with query_type X") instead of
a bare -1, in both the digest text and the orchestrator's AVAILABLE VFB DATA
block. Only drop queries actually counted as empty (count 0, no preview rows).
…est.json to the newer battery run)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the post-v3.3.0 fix on
feature/answer-quality-recipesintomain(candidate v3.3.1).Fix — false "VFB does not currently hold data" on large terms
get_term_inforeturnscount: -1for query types it did not pre-count (common for big ones — e.g. on the medullaFBbt_00003748every query in the menu is-1).-1means the data exists but wasn't counted, so the query must be run — it does not mean "no data". The term-info digest filter (lib/termInfoDigest.mjs) wasq.count > 0 || examples, which dropped every-1query, so the "Available VFB data" block shown to the model was empty and it answered "VFB does not currently hold data on the number of images of neurons with a part in the medulla" — when VFB actually holds 226,524.Because the whole menu was
-1, this affected essentially any question about a large region, not just images.Changes
buildTermInfoDigestfilter now keepscount: -1queries (q.count !== 0 || examples); only genuinely-counted-empty queries (count 0, no preview rows) are dropped.digestToTextand the orchestrator's AVAILABLE VFB DATA block rendercount < 0as an explicit instruction —run this query — call vfb_run_query with query_type X to get the count/results— instead of a bare-1, so the model knows the data exists and that it must run the query.ImagesNeurons-1fixture). Digest suite 9/9; 56/56 across the touched suites;next lintclean.Conflict note
The only merge conflict was
test-results/task-battery/latest.json— the CI-generated "latest run" snapshot, which the task-battery workflow rewrites on every push to both branches (main's run was on the PR #4 merge, feature's on the fix). Resolved by keeping the newer run (on the fix commit744d15a). This file will conflict on everyfeature → mainPR; worth a follow-up (stop trackinglatest.json, or a.gitattributes/workflow rule to auto-take one side).After merge
Tag v3.3.1 on
mainfor the versioned image build. (Prod runs thefeature-answer-quality-recipesimage, which already has the fix.)