Show the spinner during stack discovery and branch naming - #274
Merged
Merged
Conversation
Stack discovery and branch naming run before any stage opens, so the status row stayed hidden. A new ActivityStarted/ActivityEnded event pair brackets them and the terminal shows its label.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack discovery and branch naming run before any stage opens. The status row only shows while a stage is open, so nothing on screen said orca was working.
ActivityStarted(label)/ActivityEnded(), for work outside any stage.FlowLifecyclewraps discovery and branch naming in them.The dirty-tree prompt runs earlier and writes straight to stderr, so it's left without a spinner, which would draw over it.