Skip to content

Replace the shell's crashed flag with an attempt status enum - #276

Merged
adamw merged 3 commits into
masterfrom
audit/U3-crashed-status-enum
Sep 24, 2026
Merged

adamw merged 3 commits into
masterfrom
audit/U3-crashed-status-enum

Conversation

@adamw

@adamw adamw commented Sep 24, 2026

Copy link
Copy Markdown
Member

What was wrong

  • The shell passed a crashed: Boolean from the manifest reader to the picker, continue --list and the resume notice.
  • If a crashed attempt's pid was reused by another process, the attempt no longer showed as crashed.

What changed

  • New ObservedStatus enum: Running, Succeeded, Failed, Crashed. It is the manifest's status, except a Running attempt whose process is gone is Crashed.
  • continue --list --json: the crashed boolean is replaced by attemptStatus (e.g. "Crashed").
  • A live process that started more than a minute after the attempt's startedAt counts as a reused pid, so the attempt shows as crashed.

@adamw
adamw merged commit e9d760c into master Sep 24, 2026
6 checks passed
@adamw
adamw deleted the audit/U3-crashed-status-enum branch September 24, 2026 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant