Second correction accordance with the recommendations

Author: Виталий

brain_games/engine_game.py

@@ -1,21 +1,21 @@
 import prompt
 
+NUMBER_QUESTIONS = 3
 
-def run_game(displays_rules_game, generating_question_and_answer):
-    NUMBER_QUESTIONS = 3
+
+def run_game(RULES_GAME, generating_question_and_answer):
     print('Welcome to the Brain Games!')
     name = prompt.string('May I have your name? ')
     print(f'Hello, {name}!')
-    displays_rules_game()
+    print(RULES_GAME)
     for _ in range(NUMBER_QUESTIONS):
         question, right_answer = generating_question_and_answer()
         print(f"Question: {question}")
         response_user = prompt.string('Your answer: ')
-        if response_user == right_answer:
-            print('Correct!')
-        else:
+        if response_user != right_answer:
             print(f"'{response_user}' is wrong answer ;(. ", end='')
             print(f"Correct answer was '{right_answer}'.")
             print(f"Let's try again, {name}!")
             return
-    print(f"Congratulations, {name}!")
+        print('Correct!')
+    print(f"Congratulations, {name}!")        

brain_games/games/calc.py

@@ -1,16 +1,15 @@
 from random import choice, randint
 
+MIN_GEN_RANGE = 1
+MAX_GEN_RANGE = 25
+OPERATIONS = ('+', '-', '*')
+RULES_GAME = "What is the result of the expression?"
 
-def displays_rules_game():
-    print("What is the result of the expression?")
 
-
-def generating_question_and_answer():
-    MIN_GEN_RANGE = 1
-    MAX_GEN_RANGE = 25
+def generating_question_and_answer(): 
     num1 = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
     num2 = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
-    operation = choice('+-*')
+    operation = choice(OPERATIONS)
     question = f"{str(num1)} {operation} {str(num2)}"
     match operation:
         case "+":

brain_games/games/even.py

@@ -1,13 +1,11 @@
 from random import randint
 
-
-def displays_rules_game():
-    print('Answer "yes" if the number is even, otherwise answer "no".')
+MIN_GEN_RANGE = 1
+MAX_GEN_RANGE = 100
+RULES_GAME = 'Answer "yes" if the number is even, otherwise answer "no".'
 
 
 def generating_question_and_answer():
-    MIN_GEN_RANGE = 1
-    MAX_GEN_RANGE = 100
     number = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
     question = str(number)
     if number % 2 == 0:

brain_games/games/gcd.py

@@ -1,5 +1,9 @@
 from random import randint
 
+MIN_GEN_RANGE = 2
+MAX_GEN_RANGE = 10
+RULES_GAME = "Find the greatest common divisor of given numbers."
+
 
 def finding_gcd(num1, num2):       # нахождение наибольшего общего делителя
     while num1 != 0 and num2 != 0:
@@ -10,13 +14,7 @@ def finding_gcd(num1, num2):       # нахождение наибольшего
     return (num1 + num2)
 
 
-def displays_rules_game():
-    print("Find the greatest common divisor of given numbers.")
-
-
 def generating_question_and_answer():
-    MIN_GEN_RANGE = 2
-    MAX_GEN_RANGE = 10
     num1 = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
     num2 = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
     question = f"{num1} {num2}"

brain_games/games/prime.py

@@ -1,5 +1,9 @@
 from random import randint
 
+MIN_GEN_RANGE = 1
+MAX_GEN_RANGE = 130
+RULES_GAME = 'Answer "yes" if given number is prime. Otherwise answer "no".'
+
 
 # функция проверяет является ли число простым
 # если число простое -> True 
@@ -13,13 +17,7 @@ def is_prime(number):
     return True
 
 
-def displays_rules_game():
-    print('Answer "yes" if given number is prime. Otherwise answer "no".')
-
-
 def generating_question_and_answer():
-    MIN_GEN_RANGE = 1
-    MAX_GEN_RANGE = 130
     number = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
     question = str(number)
     if is_prime(number):

brain_games/games/progression.py

@@ -1,37 +1,22 @@
 from random import randint
 
-
-# функция создает арифметическую прогрессию
-def generating_a_progression(first: int, step: int, empty: int) -> str:
-    question = ''
-    for i in range(1, 11):
-        if i == empty:
-            question += '.. '
-        else:
-            question += str(first + step * (i - 1)) + ' '
-    question = question.strip()
-    return (question)
-
-
-def displays_rules_game():
-    print("What number is missing in the progression?")
+LEN_PROGRESSION = 10
+MIN_GEN_RANGE = 1
+MAX_GEN_RANGE = 50
+RULES_GAME = "What number is missing in the progression?"
 
 
 def generating_question_and_answer():
-    LEN_PROGRESSION = 10
-    MIN_GEN_RANGE = 1
-    MAX_GEN_RANGE = 50
-    #
     first_element = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
     step = randint(MIN_GEN_RANGE, MAX_GEN_RANGE)
     index_of_missing_element = randint(MIN_GEN_RANGE, LEN_PROGRESSION)
     #
     answer = str(first_element + step * (index_of_missing_element - 1))
-    question = ''
+    question = []
     for i in range(LEN_PROGRESSION):
         if i + 1 == index_of_missing_element:
-            question += '.. '
+            question.append('..')
         else:
-            question += str(first_element + step * i) + ' '
-    question = question.strip()
+            question.append(str(first_element + step * i))
+    question = ' '.join(question)
     return ((question, answer))

brain_games/scripts/brain_calc.py

@@ -1,12 +1,12 @@
 from brain_games.engine_game import run_game
 from brain_games.games.calc import (
-    displays_rules_game,
+    RULES_GAME,
     generating_question_and_answer,
 )
 
 
 def main():
-    run_game(displays_rules_game, generating_question_and_answer)
+    run_game(RULES_GAME, generating_question_and_answer)
 
 
 if __name__ == '__main__':

brain_games/scripts/brain_even.py

@@ -1,12 +1,12 @@
 from brain_games.engine_game import run_game
 from brain_games.games.even import (
-    displays_rules_game,
+    RULES_GAME,
     generating_question_and_answer,
 )
 
 
 def main():
-    run_game(displays_rules_game, generating_question_and_answer)
+    run_game(RULES_GAME, generating_question_and_answer)
 
 
 if __name__ == '__main__':

brain_games/scripts/brain_gcd.py

@@ -1,12 +1,12 @@
 from brain_games.engine_game import run_game
 from brain_games.games.gcd import (
-    displays_rules_game,
+    RULES_GAME,
     generating_question_and_answer,
 )
 
 
 def main():
-    run_game(displays_rules_game, generating_question_and_answer)
+    run_game(RULES_GAME, generating_question_and_answer)
 
 
 if __name__ == '__main__':

brain_games/scripts/brain_prime.py

@@ -1,12 +1,12 @@
 from brain_games.engine_game import run_game
 from brain_games.games.prime import (
-    displays_rules_game,
+    RULES_GAME,
     generating_question_and_answer,
 )
 
 
 def main():
-    run_game(displays_rules_game, generating_question_and_answer)
+    run_game(RULES_GAME, generating_question_and_answer)
 
 
 if __name__ == '__main__':