fix(ci): forward NEXT_PUBLIC_GTM_ID to client docker build (AM-640)#349
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
mbarrenechea
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Final missing wire for AM-640 (GA install via GTM). The previous PRs added the env var to:
client/src/env.mjs)infrastructure/)docker-compose.yml,client/Dockerfile)But the GitHub Actions workflow (
cicd.yml) explicitly enumerates eachbuild-argsline, so a new var stays invisible to the build until added here. Without this line,NEXT_PUBLIC_GTM_IDbakes in as empty string and<GoogleTagManager>never renders — which is what we observe ondev.amazoniaforever360.orgright now.GTM ID is a public identifier (visible in browser network requests), so this uses
vars.notsecrets.— matchesNEXT_PUBLIC_URL,NEXT_PUBLIC_API_URL,NEXT_PUBLIC_WEBSHOT_URL.Test plan
TF_CLIENT_NEXT_PUBLIC_GTM_IDis set as a variable (not secret) in the GitHub Environments fordevelopment,staging,production.https://dev.amazoniaforever360.org/es: accept cookies → DevTools →window.dataLayerpopulated,GET gtm.js?id=GTM-M4DCMK4fires.googletagmanager.comappears in the bundle.