fix(wayland): reliable clipboard copy and ydotool injection on non-US layouts

[fsioni]

Summary

Fixes two independent text-injection bugs on Wayland that, combined, made dictation produce nothing usable (no text in the focused field, empty clipboard) on a GNOME/Mutter + AZERTY setup.

1. Clipboard copy silently failed (_run_clipboard_command)

wl-copy (and xclip/xsel) fork a background process that keeps owning the selection in order to serve it. That child inherits the pipes created by subprocess.run(..., stderr=subprocess.PIPE), so run() blocks reading stderr until the child exits — i.e. until the clipboard is next overwritten, which may be never. The call therefore hits _clipboard_timeout and _copy_to_clipboard returns False, even though the copy actually succeeded.

Reproduced on a real session:

WARNING wl-copy failed: Command '['wl-copy', '...']' timed out after 2.5 seconds
copy_to_clipboard -> False
# ...yet:
$ wl-paste
...the exact text was on the clipboard all along

Fix: redirect stdout/stderr to DEVNULL so run() only waits for the short-lived foreground process. Measured: PIPE → timeout; DEVNULL → returns in ~0.06 s with the clipboard correctly set. I couldn't find this one reported elsewhere.

2. ydotool type scrambles text on non-US layouts (_inject_with_wayland_tool)

ydotool type emits positional evdev keycodes that the compositor re-interprets through the active keyboard layout, which ydotool assumes is US QWERTY. On AZERTY/QWERTZ/Dvorak the output is garbled (e.g. message → ,essqge, avec → qvec) and non-ASCII characters are dropped.

The code already used clipboard paste for non-ASCII text (#362); this extends it to all text when the tool is ydotool, since Ctrl+V is both layout-independent and Unicode-safe. (ydotool key Ctrl+V uses keycodes 29+47, which map to the same physical keys on QWERTY and AZERTY.)

This completes #164: that issue was closed but only the non-ASCII case was actually fixed (via #362) — plain ASCII still garbled on non-US layouts.

Tests

• tests/test_text_injector.py and tests/test_text_injector_ext.py pass.
• Updated test_ydotool_ascii_* to reflect that ydotool now always pastes.
• Added test_clipboard_command_does_not_capture_pipe as a regression guard for the PIPE→DEVNULL fix.
• black and isort clean.

Related issues

• Completes [BUG] ydotool types wrong characters on non us keyboard layouts #164 (ydotool wrong characters on non-US layouts) — remaining ASCII case.
• Builds on [BUG] The accented characters á, é, í, ó, ú, and others do not appear. #362 (accented characters via clipboard paste).
• Distinct from fix: paste into Firefox through clipboard fallback #425 (Firefox-specific clipboard fallback on the IBus path) — this is the wl-copy/xclip PIPE hang plus the ydotool ASCII case.
• Context: users land on the ydotool/clipboard path largely because the IBus backend is often a silent no-op on Wayland ([BUG] IBus backend false-positive on niri/sway Wayland so text injection silently no-ops #478, [Wayland] IBus text injection reports success but no text appears on KDE Plasma (Garuda/Arch) #380), which is what surfaced both bugs here.

Notes / scope

• wtype keeps its native Unicode typing path (it speaks the Wayland text-input protocol, so it is layout- and Unicode-correct already).
• Clipboard paste necessarily overwrites the user's clipboard for ydotool dictation; this was already the behaviour for accented text and is unavoidable with ydotool on Wayland.
• Deliberately out of scope here: the IBus-vs-ydotool backend-selection policy ([BUG] IBus backend false-positive on niri/sway Wayland so text injection silently no-ops #478) and the setxkbmap-rewrites-XWayland-to-us side effect ([BUG] 0.12.0-beta changes keyboard layout from german to US #474) — kept separate to keep this PR to two self-contained bug fixes.

https://claude.ai/code/session_01EhyratrEE4vDWhriirUB9k

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.72%. Comparing base (c64b727) to head (233af78).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #480   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          31       31           
  Lines        5068     5068           
  Branches      782      782           
=======================================
  Hits         4294     4294           
  Misses        595      595           
  Partials      179      179           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jatinkrmalik]

LGTM. Went through the clipboard copy fix and the ydotool layout handling, both look right.

[jatinkrmalik]

Merged, thanks a lot @fsioni! The scrambled output on AZERTY/QWERTZ layouts has tripped up a bunch of people, and that clipboard hang was a nasty one to track down. This ships in v0.13.0-beta.