fix(settings): English language should pick the .en model variant - #780
Open
jatinkrmalik wants to merge 1 commit into
Open
fix(settings): English language should pick the .en model variant#780jatinkrmalik wants to merge 1 commit into
jatinkrmalik wants to merge 1 commit into
Conversation
Bare size names like tiny/small/medium are also the multilingual variant ids, so a fresh config looks like a deliberate multilingual pick and the .en preference never runs. Retarget those ambiguous ids (and matching quantized pairs) when language implies English-only vs multilingual. Fixes #776.
✅ Deploy Preview for voca-linux canceled.
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
jatinkrmalik
marked this pull request as ready for review
September 5, 2026 19:40
|
| Filename | Overview |
|---|---|
| src/vocalinux/ui/settings_dialog.py | Adds guarded language-aware variant retargeting while preserving unsupported or deliberately unpaired specializations. |
| tests/test_settings_dialog.py | Covers standard, quantized, multilingual, English-only, and unpaired variant mappings. |
Reviews (1): Last reviewed commit: "fix(settings): flip whisper.cpp speciali..." | Re-trigger Greptile
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setting Language to English (US) left Specialization on Standard multilingual, while the line under it recommended Small EN. Same weight either way, better English recognition, and the UI already knew which one it wanted.
Cause: tiny/base/small/medium are both size bucket names and the multilingual specialization ids. Default config stores those bare ids, so populate treated them as a locked multilingual choice and never applied the existing .en preference helpers.
This retargets those ambiguous standard ids when language implies English-only vs multilingual, and mirrors quantized pairs the same way (medium-q5_0 <-> medium.en-q5_0). Turbo/versioned large variants with no .en pair stay put.
Fixes #776.