Skip to content

fix(settings): English language should pick the .en model variant - #780

Open
jatinkrmalik wants to merge 1 commit into
mainfrom
fix/776-english-model-variant
Open

fix(settings): English language should pick the .en model variant#780
jatinkrmalik wants to merge 1 commit into
mainfrom
fix/776-english-model-variant

Conversation

@jatinkrmalik

Copy link
Copy Markdown
Member

Setting Language to English (US) left Specialization on Standard multilingual, while the line under it recommended Small EN. Same weight either way, better English recognition, and the UI already knew which one it wanted.

Cause: tiny/base/small/medium are both size bucket names and the multilingual specialization ids. Default config stores those bare ids, so populate treated them as a locked multilingual choice and never applied the existing .en preference helpers.

This retargets those ambiguous standard ids when language implies English-only vs multilingual, and mirrors quantized pairs the same way (medium-q5_0 <-> medium.en-q5_0). Turbo/versioned large variants with no .en pair stay put.

Fixes #776.

Bare size names like tiny/small/medium are also the multilingual variant
ids, so a fresh config looks like a deliberate multilingual pick and the
.en preference never runs. Retarget those ambiguous ids (and matching
quantized pairs) when language implies English-only vs multilingual.

Fixes #776.
@netlify

netlify Bot commented Sep 5, 2026

Copy link
Copy Markdown

Deploy Preview for voca-linux canceled.

Name Link
🔨 Latest commit f91212c
🔍 Latest deploy log https://app.netlify.com/projects/voca-linux/deploys/6a9c4c8f149d780008d36894

@github-actions github-actions Bot added app Core Python application (src, packaging) tests Test suite changes labels Sep 5, 2026
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@jatinkrmalik
jatinkrmalik marked this pull request as ready for review September 5, 2026 19:40
@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown

Greptile Summary

This PR makes Whisper.cpp specialization selection follow the configured language, choosing matching English-only or multilingual variants where a valid pair exists.

  • Adds helpers to identify standard paired variants and mirror quantized English/multilingual variants.
  • Applies language-aware retargeting while populating the specialization selector.
  • Adds focused coverage for bare size identifiers, quantized pairs, automatic/non-English languages, and unpaired large variants.

Confidence Score: 5/5

The PR appears safe to merge, with no concrete changed-code failure identified.

The new mapping is constrained to known Whisper.cpp variants, checks mirrored counterparts before selecting them, and leaves variants without valid language counterparts unchanged.

Important Files Changed

Filename Overview
src/vocalinux/ui/settings_dialog.py Adds guarded language-aware variant retargeting while preserving unsupported or deliberately unpaired specializations.
tests/test_settings_dialog.py Covers standard, quantized, multilingual, English-only, and unpaired variant mappings.

Reviews (1): Last reviewed commit: "fix(settings): flip whisper.cpp speciali..." | Re-trigger Greptile

@jatinkrmalik jatinkrmalik mentioned this pull request Sep 5, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app Core Python application (src, packaging) tests Test suite changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Setting the language to English does not switch the model variant

2 participants