fix(settings): make recommended model one click and prefer on-disk

[jatinkrmalik]

Summary

Speech Model showed a recommended model as a dead label. You had to map "Small EN" onto Model Size and Specialization yourself, and it was easy to download a fresh weight when a same-size one was already local.

• Recommendation is a button that sets size and specialization together.
• Before a whisper.cpp download, if a same-size specialization is already on disk, Settings offers that instead.
• Model Size rows now show weight and a downloaded marker, matching Specialization.

Test plan

• Open Settings → Speech Model with whisper.cpp; pick something other than the recommendation; confirm the "Use recommended: …" control is a button.
• Click it; both dropdowns land on the recommended size and specialization.
• With Small multilingual on disk and Small EN recommended/selected, confirm the offer dialog appears before download and "Use Small" applies without downloading.
• Confirm Model Size entries show size + ✓/↓ like Specialization.
• pytest tests/test_recommended_model_action.py

Fixes #778

Known limits

Comparable on-disk means the same size bucket only (not a larger leftover like Medium when Small is recommended). English-only leftovers are not offered when the language is not English.

[netlify]

✅ Deploy Preview for voca-linux canceled.

Name	Link
🔨 Latest commit	7516499
🔍 Latest deploy log	https://app.netlify.com/projects/voca-linux/deploys/6a9c72b6b41c780008470c1e

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[greptile-apps]

Greptile Summary

The PR turns the speech-model recommendation into a one-click action and offers compatible, same-size models already on disk before downloading another weight.

• Adds weight and local-download indicators to whisper.cpp model-size options.
• Adds recommendation selection across model size and specialization.
• Adds comparable on-disk model selection to automatic and explicit apply flows.
• Adds focused tests for labels, recommendation clicks, comparable-model ranking, and dialog responses.

Confidence Score: 4/5

The PR appears safe to merge, with only a non-blocking type-annotation convention violation in two new settings handlers.

The recommendation and on-disk selection paths continue into the existing reconfigure-and-save flows, while the only accepted concern is missing return annotations on newly added methods.

Files Needing Attention: src/vocalinux/ui/settings_dialog.py

Important Files Changed

Filename	Overview
src/vocalinux/ui/settings_dialog.py	Implements recommendation actions, model-size status labels, and comparable on-disk model selection; two new handlers omit repository-required return annotations.
tests/test_recommended_model_action.py	Adds focused unit coverage for the recommendation and on-disk model-selection helpers and UI routing.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User selects whisper.cpp model] --> B{Requested model downloaded?}
    B -- Yes --> F[Apply and save settings]
    B -- No --> C{Same-size compatible model on disk?}
    C -- No --> D[Begin requested-model download]
    C -- Yes --> E{User choice}
    E -- Use on-disk --> F
    E -- Download --> D
    E -- Cancel --> G[Restore saved model UI]
    D --> F

Loading

_{Reviews (1): Last reviewed commit: "fix(settings): make recommended model on..." | Re-trigger Greptile}