fix: reject silent microphone captures in clamshell mode - #184
Merged
Conversation
jatinkrmalik
force-pushed
the
jmalik/fix-clamshell-silent-input
branch
from
July 14, 2026 19:30
97148bf to
843e192
Compare
jatinkrmalik
marked this pull request as ready for review
July 16, 2026 19:51
This was referenced Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(System Default)suffix from physical devices in the microphone picker.Root cause
Modern MacBooks hardware-disconnect the built-in microphone when the lid closes. macOS can continue reporting that microphone as the default input, so VocaMac receives a non-empty buffer containing digital silence. The existing empty-buffer check passes that audio to Whisper, which may generate phrases such as "thank you" or foreign-language subtitle text.
Explicitly selecting an external microphone works because VocaMac binds its AudioUnit directly to that Core Audio device.
User impact
VocaMac now rejects disconnected digital silence instead of inserting hallucinated text and tells the user how to recover. It does not silently switch microphones; users retain control over which device records audio.
Validation
swift testgit diff --check