Fix flaky nightly CI: bump main-actor blocking threshold - #185
Merged
Conversation
testStartRecordingDoesNotBlockMainActorDuringAudioStart was failing intermittently on CI runners where initial MainActor work (guard checks, state mutation, cursor overlay) took 204ms — just over the 0.2s limit. The mock audio engine's startRecordingDelay is 0.3, so the test intent is to verify the main actor doesn't synchronously wait for the full audio start duration. Matching the threshold to the mock delay (0.3) preserves the assertion while eliminating the timing flake.
github-actions
Bot
added
app
ci
question
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
testStartRecordingDoesNotBlockMainActorDuringAudioStartfails intermittently on CI runners (0.204s > 0.2s threshold).Why
The mock audio engine has
startRecordingDelay = 0.3— the test is verifying the main actor doesn't synchronously block for the full audio start duration. The 0.2 threshold was too tight: initial main-actor work (guard checks, state mutation, cursor overlay) can creep past 0.2 on slower runners.Fix
Bumped the assertion threshold from 0.2 → 0.3, matching the mock's
startRecordingDelay. The assertion remains meaningful — it still catches actual synchronous blocking (which would be ≥0.3) — while eliminating the timing flake.