You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@Mr-Sunglasses the next-recording path looks right. selectAudioDevice writes the same selectedAudioDeviceID that startRecording already passes into AudioEngine, and Settings stays in sync because it binds to those keys. Disabling the menu while isRecording matches how the engine works (device is applied at start, not live).
The helper caption is already clipped in your first screenshot: "Does not change macOS's system d...". That's the only line that says VocaMac will not steal the macOS default input, and it's unreadable. MenuBarView is 380pt wide. The permission captions in this same file wrap with .fixedSize(horizontal: false, vertical: true). This Text doesn't.
Two gaps vs AudioSettingsTab:
Settings appends " (Unavailable)" at the Picker and tells you the next recording falls back to System Default. The tray bakes "(Unavailable)" into the helper, shows a dead Text row with no checkmark, and never says that. Tray refreshAudioDevices() also writes selectedAudioDeviceName directly instead of going through selectAudioDevice.
If Settings and the tray share one picker (or one set of helpers), this won't drift. Until then, keep the display-name rules identical and show the same fallback sentence.
Nit on the new test: after selectAudioDevice(device), start a recording and assert mocks.audioEngine.lastPreferredInputDeviceID. Right now it only checks that two properties were written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Users had to open Settings to change the microphone used for dictation from VocaMac.
Demo
Summary
Verification
swift test— 359 tests passed, 3 skippedmake build— succeeded with local ad-hoc signinggit diff --check— passed