Skip to content

fix: remove rectangular overlay glow #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jatinkrmalik merged 1 commit into from
Aug 17, 2026
Merged

fix: remove rectangular overlay glow #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 8 additions & 17 deletions Sources/VocaMac/Services/CursorOverlayManager.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@ import SwiftUI

/// Shared overlay dimensions keep the AppKit panel and SwiftUI content in sync.
enum OverlayLayout {
/// Extra transparent margin so brand-green glow is not clipped by the panel.
static let glowBleed: CGFloat = 14
/// Transparent room for rounded-edge antialiasing at the native panel boundary.
static let edgeInset: CGFloat = 2

static func contentSize(for style: OverlayStyle) -> CGSize {
switch style {
Expand All @@ -30,8 +30,8 @@ enum OverlayLayout {
let content = contentSize(for: style)
guard content != .zero else { return .zero }
return CGSize(
width: content.width + glowBleed * 2,
height: content.height + glowBleed * 2
width: content.width + edgeInset * 2,
height: content.height + edgeInset * 2
)
}
}
Expand Down Expand Up @@ -507,25 +507,16 @@ struct HandyOverlayView: View {
.clipShape(RoundedRectangle(cornerRadius: cornerRadius, style: .continuous))
.overlay {
RoundedRectangle(cornerRadius: cornerRadius, style: .continuous)
.stroke(
.strokeBorder(
viewModel.phase == .recording
? brandGreen.opacity(isPulsing ? 0.95 : 0.55)
: strokeBase,
lineWidth: viewModel.phase == .recording ? 1.6 : 1
)
}
.shadow(
color: accentColor.opacity(viewModel.phase == .recording ? (isPulsing ? 0.75 : 0.4) : 0.28),
radius: 11,
y: 0
)
.shadow(
color: Color.black.opacity(isDark ? 0.45 : 0.18),
radius: 8,
y: 3
)
// Transparent bleed so the glow is not clipped by the NSPanel bounds.
.padding(OverlayLayout.glowBleed)
// Leave only enough transparent room for rounded-edge antialiasing.
// There is deliberately no outer shadow that could reveal panel bounds.
.padding(OverlayLayout.edgeInset)
.frame(width: panelSize.width, height: panelSize.height)
.opacity(viewModel.isActive && hasEntered ? 1 : 0)
.offset(y: hasEntered ? 0 : slideInOffset)
Expand Down
8 changes: 3 additions & 5 deletions Tests/VocaMacTests/CursorOverlayTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,18 +41,16 @@ final class OverlayLayoutTests: XCTestCase {

func testMinimalOverlayUsesCompactStableDimensions() {
XCTAssertEqual(OverlayLayout.contentSize(for: .minimal), CGSize(width: 108, height: 44))
let size = OverlayLayout.size(for: .minimal)
XCTAssertEqual(size.width, 108 + OverlayLayout.glowBleed * 2)
XCTAssertEqual(size.height, 44 + OverlayLayout.glowBleed * 2)
XCTAssertEqual(OverlayLayout.size(for: .minimal), CGSize(width: 112, height: 48))
}

func testLiveOverlayIsShorterThanTheOriginalPanel() {
let content = OverlayLayout.contentSize(for: .live)
let size = OverlayLayout.size(for: .live)

XCTAssertEqual(content, CGSize(width: 240, height: 72))
XCTAssertEqual(size.width, 240 + OverlayLayout.glowBleed * 2)
XCTAssertLessThan(content.width, 360)
XCTAssertEqual(size, CGSize(width: 244, height: 76))
XCTAssertLessThan(size.width, 360)
}
}

Expand Down
Loading