Add a dictation tone picker - #227
Merged
Merged
Conversation
Settings can choose a start/stop cue from the family catalog. Unset preferences resolve to voca. Off is stored as a silent tone.
NSSound stays retained until the finish callback. If play() fails, that callback never arrives, so drop the sound and finish the waiter.
jatinkrmalik
marked this pull request as ready for review
August 19, 2026 00:47
Turning effects off in one recording test wrote UserDefaults and left later cases with the switch off, so start/stop cues were skipped.
Mac now ships the start/stop bytes from VocaLinux #707. Windows #15 has the same catalog but different samples, so those were not used. The in-app oscillator is gone.
The Linux remakes did not match the shared preview WAVs. Mac now ships those exact start/stop files. Voca start is 19448 bytes.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings → Audio now has a tone menu next to the sound-effects switch.
The catalog is lift, flick, ember, step, voca, soft, chirp, scale, drop, glass, and off. New installs and anyone with no saved tone id get Voca. A stored id, including Off, is left as-is.
The bundled start/stop files are the preview pair WAVs (
pairs/01-linux-glidethroughpairs/10-glass).05-fifthis Voca, the default. Those files replace the Linux remakes, which did not match. Voca start is 19448 bytes, 16-bit mono 44.1 kHz.There is no in-app oscillator. Preview plays start, then stop. Off preview is disabled. The sound-effects switch still gates recording cues. Off stays silent even when that switch is on.