Site: honest offline copy, privacy engines, copy a11y - #247
Merged
Conversation
✅ Deploy Preview for voca-mac ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
app
ci
enhancement
jatinkrmalik
marked this pull request as ready for review
September 1, 2026 19:56
|
| Filename | Overview |
|---|---|
| web/static/script.js | The click-time generation token suppresses out-of-order clipboard settlements, while the shared guarded timer prevents older feedback from clearing newer feedback. |
| web/tests/site.test.mjs | Regression assertions now match the token-aware feedback implementation rather than the removed literal announcement calls. |
| web/layouts/index.html | The privacy route now uses an engine-neutral label and enumerates the supported on-device options. |
| web/layouts/features/single.html | Removes the article-wide aria-labelledby relationship without disturbing the rendered feature content. |
| netlify.toml | Pins Hugo 0.165.0 for Netlify while leaving the UI-managed build paths unchanged. |
Reviews (4): Last reviewed commit: "Tie site copy feedback to click-time gen..." | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Use one generation token and a shared restore timer so a second click cannot let an older timeout wipe newer Copied feedback.
Advance the shared token on click so a slower clipboard settle from an earlier request cannot overwrite newer button or live-region state. Keep site tests aligned with the requestToken helpers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vocamac.com audit in #246. Shipping status stays Beta v0.9.0.
The clipboard comparison table no longer says Works offline. It says on-device transcription after model download.
The homepage privacy route labels the chip step Selected on-device engine and lists WhisperKit/CoreML, Parakeet, Apple Speech, and ONNX.
Feature pages no longer point aria-labelledby at the whole article.
Copy buttons announce Copied or Press ⌘C through a polite live region.
The social preview is the VocaDesign v0.9.0 card at /og-image.png. Proof line is macOS 14+ · Apple Silicon · v0.9.0 beta · AGPL-3.0.
Repo-root netlify.toml pins HUGO_VERSION to 0.165.0 so deploy-preview finds web/hugo.toml. It does not change the Netlify UI base, command, or publish path.
Draft until CI is green.