Skip to content

Fix wrapping in the silence duration field - #249

Merged
jatinkrmalik merged 2 commits into
mainfrom
fix/silence-duration-layout
Sep 5, 2026
Merged

Fix wrapping in the silence duration field#249
jatinkrmalik merged 2 commits into
mainfrom
fix/silence-duration-layout

Conversation

@jatinkrmalik

Copy link
Copy Markdown
Member

Summary

  • hide the text field label that appears as Sec-onds in the Silence Detection settings
  • keep the label available to accessibility while the visible seconds unit stays beside the input

Testing

  • swift test (442 tests passed, with 1 expected Accessibility skip)

@netlify

netlify Bot commented Sep 3, 2026

Copy link
Copy Markdown

Deploy Preview for voca-mac canceled.

Name Link
🔨 Latest commit 828c23b
🔍 Latest deploy log https://app.netlify.com/projects/voca-mac/deploys/6a9bb272aeed9b0007b56115

@greptile-apps

greptile-apps Bot commented Sep 3, 2026

Copy link
Copy Markdown

Greptile Summary

The PR prevents the silence-duration field label from wrapping while retaining the visible unit beside the input.

  • Adds .labelsHidden() to the silence-duration TextField.
  • Leaves the field formatting, sizing, and adjacent seconds text unchanged.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains within the eligible follow-up-review scope.

No blocking failure remains.

Important Files Changed

Filename Overview
Sources/VocaMac/Views/SettingsView.swift Hides the silence-duration field label to prevent visual wrapping; no eligible follow-up finding was established.

Reviews (3): Last reviewed commit: "Merge branch 'main' into fix/silence-dur..." | Re-trigger Greptile

@jatinkrmalik

Copy link
Copy Markdown
Member Author

/build

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

PR Build started for 6f2fd12

Build signed & notarized DMG... this usually takes 10–20 minutes.

Watch the build →

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

PR Build ready!

DMG VocaMac-0.9.0-pr.249+6f2fd12-arm64.dmg
Size 29M
Branch fix/silence-duration-layout
Commit 6f2fd12
Signed ✅ Developer ID
Notarized ✅ Apple

📥 Install

  1. Click the DMG link above to download
  2. Open the DMG and drag VocaMac to Applications (replace existing)
  3. Open VocaMac — No Gatekeeper warnings, no permission resets
SHA-256 checksum
5578af2f27499afe963cda33885e3d97c9190f5666a9e9bf27dc82ed2e7e8dce  VocaMac-0.9.0-pr.249+6f2fd12-arm64.dmg

💡 Comment /build or /build-quick to rebuild.

@jatinkrmalik
jatinkrmalik force-pushed the fix/silence-duration-layout branch from 6f2fd12 to 53a2880 Compare September 4, 2026 07:09
@github-actions github-actions Bot removed the ci label Sep 4, 2026
@jatinkrmalik
jatinkrmalik merged commit 92ccb69 into main Sep 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant