fix: App icon not displaying in Finder and DMG - #41
Merged
Conversation
- Add CFBundleIconName to Info.plist alongside CFBundleIconFile — modern macOS requires both keys for the icon to render in Finder - Fix @2x icon DPI from 72 to 144 for proper Retina display support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VocaMac shows a generic white icon in Finder, Applications folder, and when mounted from DMG — despite the
.icnsfile being present and correctly referenced inInfo.plist.Root Cause
Two issues:
Missing
CFBundleIconNamekey — Modern macOS (13+) requires bothCFBundleIconFileandCFBundleIconNameinInfo.plistfor the icon to render. We only hadCFBundleIconFile.Incorrect DPI on @2x icons — The @2x icon variants had 72 DPI instead of the expected 144 DPI, which can confuse macOS's icon rendering.
Fix
CFBundleIconNamekey to theInfo.plistgenerated bybuild.shAppIcon.icnswith correct DPI values (72 for 1x, 144 for @2x)Tested
.appbundle