chore: Add Makefile and restructure install.sh for /Applications install - #43
Merged
Merged
Conversation
- install.sh (default): builds .app bundle via build.sh, copies to /Applications, and launches. Permissions are granted directly to VocaMac — no terminal permission workarounds needed. - install.sh --cli: keeps the old behavior — installs vocamac and vocamac-build CLI commands to ~/.local/bin - Makefile: make install, make build, make install-cli, make test, make run, make clean, make help - Updated README Quick Start: DMG as Option 1, make install as Option 2, make install-cli as Option 3 - Updated AGENTS.md and ARCHITECTURE.md build sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Building from source and running
open VocaMac.appfrom the repo root causes permission issues — macOS assigns permissions to Terminal instead of VocaMac. Users had to figure out the workaround themselves.Solution
New install.sh (two modes)
./scripts/install.sh.app, copy to/Applications, launch. Permissions go to VocaMac directly../scripts/install.sh --clivocamac+vocamac-buildCLI commands to~/.local/bin(old behavior).Makefile
make installmake install-climake buildmake testmake runmake cleanmake helpQuick start is now:
git clone https://github.com/jatinkrmalik/vocamac.git cd vocamac make installDocs updated
What stays the same
build.sh— unchanged, still the fast dev iteration tooluninstall.sh— unchangedswift build+swift test+build.sh release)