fix: Compile Asset Catalog for app icon to display in Finder - #44
Merged
Conversation
Modern macOS requires a compiled Asset Catalog (Assets.car) for app icons to render in Finder. The raw .icns file alone is not sufficient when CFBundleIconName is set. build.sh now: 1. Copies the .icns file (fallback) 2. Extracts PNGs from the .icns via iconutil 3. Compiles an Asset Catalog via actool (xcrun) 4. Falls back gracefully if actool is unavailable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
VocaMac shows a generic white icon in Finder and DMG when built on CI, despite the
.icnsfile and bothCFBundleIconFile/CFBundleIconNamebeing present.The icon worked locally but not from CI-built DMGs.
Root Cause
Modern macOS requires a compiled Asset Catalog (
Assets.car) for app icons to render in Finder whenCFBundleIconNameis set. The raw.icnsfile alone is not sufficient.Our local builds had
Assets.carfrom a previousactooltest, but the CI builds never generated it.Fix
Updated
build.shto compile an Asset Catalog as part of every build:.icnsfile (kept as fallback).icnsviaiconutil.xcassetsstructure withContents.jsonAssets.carviaxcrun actoolactoolis unavailableTested
.appbundleNote
The v0.1.1 release has been deleted. After merging this PR, we'll re-tag and re-release v0.1.1 with the icon fix included.