impl bytemuck::Pod and Zeroable for Archivedf16 and Archivedbf16#149
Open
AlJohri wants to merge 1 commit into
Open
impl bytemuck::Pod and Zeroable for Archivedf16 and Archivedbf16#149AlJohri wants to merge 1 commit into
AlJohri wants to merge 1 commit into
Conversation
Pod requires Copy, so also adds `#[rkyv(derive(Copy, Clone))]` on the source structs. Lets downstream users with both `rkyv` and `bytemuck` features safely cast slices between the rkyv archive form and native via `bytemuck::cast_slice` instead of an unsafe `from_raw_parts`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets users with both
rkyvandbytemuckfeatures usebytemuck::cast_slicebetween the rkyv archive form and native. Pod requires Copy, so also adds#[rkyv(derive(Copy, Clone))]on the source structs.