Derive zerocopy traits on Archivedf16 and Archivedbf16#150
Open
AlJohri wants to merge 1 commit into
Open
Conversation
AlJohri
force-pushed
the
zerocopy-on-archived-f16-slim
branch
from
aa2d78e to
1624bed
Compare
With the `rkyv` feature enabled, derive `zerocopy::FromBytes`, `IntoBytes`, `Immutable`, and `KnownLayout` on the generated `Archivedf16` / `Archivedbf16` so they can be used with zerocopy's safe APIs (e.g. `zerocopy::Ref::from_bytes`). The archived types wrap `rend`'s little-endian primitives, and zerocopy's traits are sealed (no manual `unsafe impl`), so the derive needs those inner types to already implement them. The `rkyv` feature therefore also pulls in `rend` directly with its `zerocopy-0_8` feature.
AlJohri
force-pushed
the
zerocopy-on-archived-f16-slim
branch
from
1624bed to
db77515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Derives
zerocopy::FromBytes/IntoBytes/Immutable/KnownLayoutonArchivedf16/Archivedbf16when therkyvfeature is enabled, so the archived types work with zerocopy's safe APIs (e.g.zerocopy::Ref::from_bytes).