Skip to content

fix(core): add package name validation to updateAllPackages #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
octo-patch wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(core): add package name validation to updateAllPackages #1250

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ad503c
fix(core): add package name validation to updateAllPackages (fixes #1…
Apr 26, 2026
63a2cc7
fix(core): warn-log invalid package names instead of dropping silently
octo-patch Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-updateallpackages-validation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@voltagent/core": patch
---

fix(core): add package name validation to updateAllPackages to prevent command injection
10 changes: 10 additions & 0 deletions packages/core/src/utils/update/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,11 +332,21 @@ export const updateAllPackages = async (
const packageManager = detectPackageManager(rootDir);

// 3. Prepare the package list for updating
const validPkgName = /^(@[a-z0-9-~][a-z0-9-._~]*\/)?[a-z0-9-~][a-z0-9-._~]*$/;
const packagesToUpdate = updateCheckResult.updates
.filter((pkg) => pkg.type !== "latest")
.filter((pkg) => validPkgName.test(pkg.name))
.map((pkg) => `${pkg.name}@latest`);

const logger = new LoggerProxy({ component: "update-checker" });

if (packagesToUpdate.length === 0) {
return {
success: true,
message: "No packages to update after filtering invalid package names",
};
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
Outdated

logger.info(`Updating ${packagesToUpdate.length} packages in ${rootDir}`);

// 4. Run the update command based on package manager
Expand Down
Loading