feat(data-table): implement basic components (VIV-3070) #2691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpawnAtis
force-pushed
the
VIV-3060-basic-data-grid
branch
from
cbf361f to
a098a86
Compare
SpawnAtis
force-pushed
the
VIV-3060-basic-data-grid
branch
from
a098a86 to
6538196
Compare
SpawnAtis
force-pushed
the
VIV-3060-basic-data-grid
branch
from
6538196 to
270553c
Compare
Contributor
View Diffdiff --git a/libs/components/metadata.json b/libs/components/metadata.json
index 7934574..e2369e4 100644
--- a/libs/components/metadata.json
+++ b/libs/components/metadata.json
@@ -8596,7 +8596,7 @@
{
"name": "table",
"className": "Table",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8648,7 +8648,7 @@
{
"name": "table-body",
"className": "TableBody",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8700,7 +8700,7 @@
{
"name": "table-cell",
"className": "TableCell",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8752,7 +8752,7 @@
{
"name": "table-head",
"className": "TableHead",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8804,7 +8804,7 @@
{
"name": "table-header-cell",
"className": "TableHeaderCell",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8856,7 +8856,7 @@
{
"name": "table-row",
"className": "TableRow",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -10489,5 +10489,5 @@
}
}
],
- "iconsManifestUrl": "https://icon.resources.vonage.com/v4.6.9/manifest.json"
+ "iconsManifestUrl": "https://icon.resources.vonage.com/v4.7.0/manifest.json"
} |
SpawnAtis
force-pushed
the
VIV-3060-basic-data-grid
branch
from
a4eeffc to
270553c
Compare
Contributor
View Diffdiff --git a/libs/components/metadata.json b/libs/components/metadata.json
index 7934574..e2369e4 100644
--- a/libs/components/metadata.json
+++ b/libs/components/metadata.json
@@ -8596,7 +8596,7 @@
{
"name": "table",
"className": "Table",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8648,7 +8648,7 @@
{
"name": "table-body",
"className": "TableBody",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8700,7 +8700,7 @@
{
"name": "table-cell",
"className": "TableCell",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8752,7 +8752,7 @@
{
"name": "table-head",
"className": "TableHead",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8804,7 +8804,7 @@
{
"name": "table-header-cell",
"className": "TableHeaderCell",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8856,7 +8856,7 @@
{
"name": "table-row",
"className": "TableRow",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -10489,5 +10489,5 @@
}
}
],
- "iconsManifestUrl": "https://icon.resources.vonage.com/v4.6.9/manifest.json"
+ "iconsManifestUrl": "https://icon.resources.vonage.com/v4.7.0/manifest.json"
} |
SpawnAtis
force-pushed
the
VIV-3060-basic-data-grid
branch
from
cd2cc5e to
e025884
Compare
Contributor
View Diffdiff --git a/libs/components/metadata.json b/libs/components/metadata.json
index 7934574..e2369e4 100644
--- a/libs/components/metadata.json
+++ b/libs/components/metadata.json
@@ -8596,7 +8596,7 @@
{
"name": "table",
"className": "Table",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8648,7 +8648,7 @@
{
"name": "table-body",
"className": "TableBody",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8700,7 +8700,7 @@
{
"name": "table-cell",
"className": "TableCell",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8752,7 +8752,7 @@
{
"name": "table-head",
"className": "TableHead",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8804,7 +8804,7 @@
{
"name": "table-header-cell",
"className": "TableHeaderCell",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -8856,7 +8856,7 @@
{
"name": "table-row",
"className": "TableRow",
- "registerFunctionName": "registerTable",
+ "registerFunctionName": "registerDataTable",
"description": "",
"props": [],
"events": [
@@ -10489,5 +10489,5 @@
}
}
],
- "iconsManifestUrl": "https://icon.resources.vonage.com/v4.6.9/manifest.json"
+ "iconsManifestUrl": "https://icon.resources.vonage.com/v4.7.0/manifest.json"
} |
SpawnAtis
force-pushed
the
VIV-3060-basic-data-grid
branch
from
b6ec06f to
19d1fbc
Compare
| /** | ||
| * @internal | ||
| */ | ||
| override connectedCallback(): void { |
Contributor
There was a problem hiding this comment.
I don't think this override is necessary.
SpawnAtis
force-pushed
the
VIV-3060-basic-data-grid
branch
from
19d1fbc to
1df4280
Compare
Contributor
View Diffdiff --git a/libs/components/metadata.json b/libs/components/metadata.json
index 4415ada..e2369e4 100644
--- a/libs/components/metadata.json
+++ b/libs/components/metadata.json
@@ -10489,5 +10489,5 @@
}
}
],
- "iconsManifestUrl": "https://icon.resources.vonage.com/v4.6.9/manifest.json"
+ "iconsManifestUrl": "https://icon.resources.vonage.com/v4.7.0/manifest.json"
} |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2691 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 430 444 +14
Lines 10216 10244 +28
Branches 1885 1885
=========================================
+ Hits 10216 10244 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SpawnAtis
force-pushed
the
VIV-3060-basic-data-grid
branch
from
29cb6a1 to
ae5a150
Compare
Contributor
View Diffdiff --git a/libs/components/metadata.json b/libs/components/metadata.json
index 4415ada..e2369e4 100644
--- a/libs/components/metadata.json
+++ b/libs/components/metadata.json
@@ -10489,5 +10489,5 @@
}
}
],
- "iconsManifestUrl": "https://icon.resources.vonage.com/v4.6.9/manifest.json"
+ "iconsManifestUrl": "https://icon.resources.vonage.com/v4.7.0/manifest.json"
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.