Skip to content

feat: Add support for custom HTTP requests #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

SMadani
Copy link
Contributor

@SMadani SMadani commented Apr 9, 2025

This PR allows users of the SDK to declaratively make custom requests with their own JSON-based request and response types and to specify the URL and HTTP method, whilst automatically handling the authentication, serialisation and deserialisation. This is implemented as methods on the new CustomClient class, accessible from VonageClient#getCustomClient().

@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.87%. Comparing base (281a3b3) to head (a60e8de).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #581   +/-   ##
=========================================
  Coverage     99.87%   99.87%           
- Complexity     3395     3412   +17     
=========================================
  Files           515      516    +1     
  Lines          7320     7347   +27     
  Branches        403      406    +3     
=========================================
+ Hits           7311     7338   +27     
  Misses            3        3           
  Partials          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants