Skip to content

Fix #52 - cast 'NUMBER_SEARCH_CRITERIA' as (string). #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix #52 - cast 'NUMBER_SEARCH_CRITERIA' as (string). #60

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13ceb76
Fix issue #51: add environment variable placeholders for FROM_NUMBER …
gthoffer Oct 2, 2020
082a58c
Fix #52 - cast 'NUMBER_SEARCH_CRITERIA' as (string). Added comment t…
gthoffer Oct 2, 2020
f4a94f2
Fix #52 - cast 'NUMBER_SEARCH_CRITERIA' as (string). Added comment t…
gthoffer Oct 2, 2020
fc566f7
fix: remove unnecessary comment information
gthoffer Oct 5, 2020
22b8530
fix: remove unnecessary comment information
gthoffer Oct 5, 2020
e33d828
Merge branch '52_numbers_search_pattern_exception' of https://github.…
gthoffer Oct 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion numbers/search-available.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,17 @@
$client = new \Vonage\Client($basic);

/** @var IterableAPICollection $response */
/** Note: be careful when specifying "NUMBER_SEARCH_CRITERIA" environment variable:
* surround it with quotes if it has a leading zero, otherwise the (string) conversion
* will assume it is an Octal number and convert it. e.g., (string)0123 results in "83".
* NUMBER_SEARCH_PATTERN will be one of 0 (search for numbers that start with pattern);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the warning above, but an we remove the options listed here? The allowed options are all listed on https://developer.nexmo.com/numbers/code-snippets/search-available/php, and it's expected that these snippets are being used with the documentation versus stand-alone.

* 1 (search for numbers that contain pattern), or 2 (search for numbers that end with pattern).
* VONAGE_NUMBER_TYPE must be one of: landline, mobile-lvn or landline-toll-free
* VONAGE_NUMBER_FEATURES Must be one of: SMS, VOICE, SMS,VOICE, MMS, SMS,MMS, VOICE,MMS
* or SMS,MMS,VOICE
*/
$filter = new AvailableNumbers([
"pattern" => (int) NUMBER_SEARCH_CRITERIA,
"pattern" => (string)NUMBER_SEARCH_CRITERIA,
"search_pattern" => (int) NUMBER_SEARCH_PATTERN,
"type" => VONAGE_NUMBER_TYPE,
"features" => VONAGE_NUMBER_FEATURES,
Expand Down