VIDSOL-843: fix rejoining maestro test and enable it#140
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Improves the Maestro E2E flow that joins a room, ends the call, and re-enters the meeting from the goodbye screen, by making the join steps more reliable when the soft keyboard is present.
Changes:
- Hide the on-screen keyboard after entering the room name.
- Hide the on-screen keyboard after entering the username.
Comments suppressed due to low confidence (2)
.maestro/flows/goodbye-reenter-room.yaml:20
- Other Maestro flows clear text fields before typing to avoid flaky behavior when the app is resumed with previous state or autofill (e.g.,
.maestro/flows/goodbye-view-landing-page.yaml:18-23,join-with-camera-mic-allowed.yaml:20-25). Here the room name field isn’t cleared beforeinputText, so the test can append to existing text and fail to join the expected room.
.maestro/flows/goodbye-reenter-room.yaml:37 - For consistency with other Maestro flows and to avoid appending to a prefilled username (see
.maestro/flows/goodbye-view-landing-page.yaml:37-42), clear the username field before typing. Without this, a resumed app state can causeinputTextto append and make the join step fail.
🎭 Maestro E2E Test Results✅ All tests passed!
📊 Artifacts:
📸 View the complete test results and screenshots in the artifacts section above. |
AI Adoption Report
Per-commit breakdown (1 commits)
Powered by Git AI Standard v3.0.0 — authorship data from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
How should this be manually tested?
What are the relevant tickets?
VIDSOL-843
Checklist
develop(notmain).Known Issue.docs/KNOWN_ISSUES.md?Issues.Justification for skipping ci, if applied?