VIDSOL-442: Remove warn logs from publisher#335
Open
Conversation
…cross multiple components
…isher and useDevices tests
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes debug/dogfooding warning logs from publisher-related code and replaces some warning logs with error logs where appropriate. The changes improve log hygiene by eliminating verbose diagnostic logging that was only needed during development.
Changes:
- Removed multiple
console.warnstatements from publisher lifecycle events and subscription handling - Changed
console.warntoconsole.errorfor actual error conditions - Updated corresponding test expectations to reflect the logging changes
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libs/core/src/stores/devices/DevicesContext.ts | Changed unsupported enumerateDevices warning to error |
| frontend/src/utils/VonageVideoClient/vonageVideoClient.ts | Removed subscriber and publisher diagnostic warn logs |
| frontend/src/hooks/useNetworkTest.tsx | Changed network test error warning to error |
| frontend/src/hooks/useDevices.tsx | Changed unsupported enumerateDevices warning to error |
| frontend/src/hooks/tests/useDevices.spec.tsx | Updated test to expect error instead of warn |
| frontend/src/components/MeetingRoom/ReportIssue/FeedbackForm/FilePicker/FilePicker.tsx | Changed screenshot error warning to error |
| frontend/src/Context/SessionProvider/session.tsx | Removed subscription error diagnostic warn log |
| frontend/src/Context/PublisherProvider/usePublisher/usePublisher.tsx | Removed extensive publisher lifecycle warn logs; changed error warnings to errors; removed unused dependencies from useCallback |
| frontend/src/Context/PublisherProvider/usePublisher/usePublisher.spec.tsx | Updated test expectations for error instead of warn |
| frontend/src/Context/PreviewPublisherProvider/usePreviewPublisher/usePreviewPublisher.tsx | Changed publisher destruction warning to error |
| frontend/src/Context/BackgroundPublisherProvider/useBackgroundPublisher/useBackgroundPublisher.tsx | Changed publisher destruction warning to error |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
johnny-quesada-developer
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR doing?
Removing warn logs from publisher that were only used for dogfooding.
How should this be manually tested?
X
What are the relevant tickets?
A maintainer will add this ticket number.
Resolves VIDSOL-442
Checklist
[X] Branch is based on
develop(notmain).[ ] Resolves a
Known Issue.[ ] If yes, did you remove the item from the
docs/KNOWN_ISSUES.md?[ ] Resolves an item reported in
Issues.If yes, which issue? Issue Number?