Add support for adding directories #288

dgudim · 2025-12-10T20:52:18Z

This little PR adds support for adding directories by iterating it (the directory) recursively and adding each file.

Bumps [taiki-e/create-gh-release-action](https://github.com/taiki-e/create-gh-release-action) from 1.8.0 to 1.8.1. - [Release notes](https://github.com/taiki-e/create-gh-release-action/releases) - [Changelog](https://github.com/taiki-e/create-gh-release-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/create-gh-release-action@v1.8.0...v1.8.1) --- updated-dependencies: - dependency-name: taiki-e/create-gh-release-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.81 to 1.0.82. - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.81...1.0.82) --- updated-dependencies: - dependency-name: anyhow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [taiki-e/upload-rust-binary-action](https://github.com/taiki-e/upload-rust-binary-action) from 1.19.2 to 1.20.0. - [Release notes](https://github.com/taiki-e/upload-rust-binary-action/releases) - [Changelog](https://github.com/taiki-e/upload-rust-binary-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/upload-rust-binary-action@v1.19.2...v1.20.0) --- updated-dependencies: - dependency-name: taiki-e/upload-rust-binary-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [rustls](https://github.com/rustls/rustls) from 0.21.10 to 0.21.11. - [Release notes](https://github.com/rustls/rustls/releases) - [Changelog](https://github.com/rustls/rustls/blob/main/CHANGELOG.md) - [Commits](rustls/rustls@v/0.21.10...v/0.21.11) --- updated-dependencies: - dependency-name: rustls dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [taiki-e/create-gh-release-action](https://github.com/taiki-e/create-gh-release-action) from 1.8.1 to 1.8.2. - [Release notes](https://github.com/taiki-e/create-gh-release-action/releases) - [Changelog](https://github.com/taiki-e/create-gh-release-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/create-gh-release-action@v1.8.1...v1.8.2) --- updated-dependencies: - dependency-name: taiki-e/create-gh-release-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [thiserror](https://github.com/dtolnay/thiserror) from 1.0.58 to 1.0.59. - [Release notes](https://github.com/dtolnay/thiserror/releases) - [Commits](dtolnay/thiserror@1.0.58...1.0.59) --- updated-dependencies: - dependency-name: thiserror dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [winnow](https://github.com/winnow-rs/winnow) from 0.6.6 to 0.6.7. - [Changelog](https://github.com/winnow-rs/winnow/blob/main/CHANGELOG.md) - [Commits](winnow-rs/winnow@v0.6.6...v0.6.7) --- updated-dependencies: - dependency-name: winnow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [winnow](https://github.com/winnow-rs/winnow) from 0.6.7 to 0.6.8. - [Changelog](https://github.com/winnow-rs/winnow/blob/main/CHANGELOG.md) - [Commits](winnow-rs/winnow@v0.6.7...v0.6.8) --- updated-dependencies: - dependency-name: winnow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

…ease This allows fixing bugs without making a release (if there are no breaking changes)

Bumps [actions/configure-pages](https://github.com/actions/configure-pages) from 4 to 5. - [Release notes](https://github.com/actions/configure-pages/releases) - [Commits](actions/configure-pages@v4...v5) --- updated-dependencies: - dependency-name: actions/configure-pages dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>

…e some additional lints)

Bumps [winnow](https://github.com/winnow-rs/winnow) from 0.6.8 to 0.6.9. - [Changelog](https://github.com/winnow-rs/winnow/blob/main/CHANGELOG.md) - [Commits](winnow-rs/winnow@v0.6.8...v0.6.9) --- updated-dependencies: - dependency-name: winnow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [taiki-e/upload-rust-binary-action](https://github.com/taiki-e/upload-rust-binary-action) from 1.20.0 to 1.21.0. - [Release notes](https://github.com/taiki-e/upload-rust-binary-action/releases) - [Changelog](https://github.com/taiki-e/upload-rust-binary-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/upload-rust-binary-action@v1.20.0...v1.21.0) --- updated-dependencies: - dependency-name: taiki-e/upload-rust-binary-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>

docs: Update basics.md: Fix small typo

Bumps [regex](https://github.com/rust-lang/regex) from 1.10.4 to 1.10.5. - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.10.4...1.10.5) --- updated-dependencies: - dependency-name: regex dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps [winnow](https://github.com/winnow-rs/winnow) from 0.6.11 to 0.6.13. - [Changelog](https://github.com/winnow-rs/winnow/blob/main/CHANGELOG.md) - [Commits](winnow-rs/winnow@v0.6.11...v0.6.13) --- updated-dependencies: - dependency-name: winnow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps the actions group with 2 updates: [taiki-e/install-action](https://github.com/taiki-e/install-action) and [github/codeql-action](https://github.com/github/codeql-action). Updates `taiki-e/install-action` from 2.62.28 to 2.62.33 - [Release notes](https://github.com/taiki-e/install-action/releases) - [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/install-action@e7ef886...e43a502) Updates `github/codeql-action` from 4.30.8 to 4.30.9 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@f443b60...16140ae) --- updated-dependencies: - dependency-name: taiki-e/install-action dependency-version: 2.62.33 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: github/codeql-action dependency-version: 4.30.9 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps the minor group with 1 update: [regex](https://github.com/rust-lang/regex). Updates `regex` from 1.12.1 to 1.12.2 - [Release notes](https://github.com/rust-lang/regex/releases) - [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md) - [Commits](rust-lang/regex@1.12.1...1.12.2) --- updated-dependencies: - dependency-name: regex dependency-version: 1.12.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps the actions group with 3 updates: [taiki-e/install-action](https://github.com/taiki-e/install-action), [actions/upload-artifact](https://github.com/actions/upload-artifact) and [github/codeql-action](https://github.com/github/codeql-action). Updates `taiki-e/install-action` from 2.62.33 to 2.62.38 - [Release notes](https://github.com/taiki-e/install-action/releases) - [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/install-action@e43a502...c5b1b6f) Updates `actions/upload-artifact` from 4.6.2 to 5.0.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@ea165f8...330a01c) Updates `github/codeql-action` from 4.30.9 to 4.31.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@16140ae...4e94bd1) --- updated-dependencies: - dependency-name: taiki-e/install-action dependency-version: 2.62.38 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: actions/upload-artifact dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: github/codeql-action dependency-version: 4.31.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps the actions group with 2 updates: [taiki-e/install-action](https://github.com/taiki-e/install-action) and [github/codeql-action](https://github.com/github/codeql-action). Updates `taiki-e/install-action` from 2.62.41 to 2.62.45 - [Release notes](https://github.com/taiki-e/install-action/releases) - [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/install-action@1d76762...81ee1d4) Updates `github/codeql-action` from 4.31.0 to 4.31.2 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@4e94bd1...0499de3) --- updated-dependencies: - dependency-name: taiki-e/install-action dependency-version: 2.62.45 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions - dependency-name: github/codeql-action dependency-version: 4.31.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps the minor group with 1 update: [duct](https://github.com/oconnor663/duct.rs). Updates `duct` from 1.1.0 to 1.1.1 - [Commits](oconnor663/duct.rs@1.1.0...1.1.1) --- updated-dependencies: - dependency-name: duct dependency-version: 1.1.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: minor ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps the actions group with 1 update: [taiki-e/install-action](https://github.com/taiki-e/install-action). Updates `taiki-e/install-action` from 2.62.45 to 2.62.49 - [Release notes](https://github.com/taiki-e/install-action/releases) - [Changelog](https://github.com/taiki-e/install-action/blob/main/CHANGELOG.md) - [Commits](taiki-e/install-action@81ee1d4...44c6d64) --- updated-dependencies: - dependency-name: taiki-e/install-action dependency-version: 2.62.49 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]>

Bumps the actions group with 1 update in the / directory: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 5.0.0 to 6.0.0 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@08c6903...1af3b93) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 6.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions ... Signed-off-by: dependabot[bot] <[email protected]>

VorpalBlade · 2025-12-11T16:04:49Z

I like the idea, but I don't think it should be the default. It is too easy to fat finger and end up adding a lot of files by mistake.

So I propose that directories will need -r/--recursive to be added, and if a a directory is passed without that, the error message should suggest adding -r.

I haven't had time to look at the code I've been on my phone all day and would need to sit down at a computer to be able to review it properly. Hopefully by Sunday I should have some time.

dgudim · 2025-12-11T21:22:57Z

Yeah, sounds reasonable, I went ahead and added it. Updated tests and docs while at it.

VorpalBlade

Good job over all! Only minor changes needed.

One thing to note is that the CI check for rustfmt is failing. You likely need to run cargo fmt --all.

src/add.rs

src/add/tests.rs

src/add.rs

README.md

src/add.rs

…irectory without --recursive

dgudim · 2025-12-15T09:43:07Z

Heck, I f*ed-up the branch 😅

dgudim · 2025-12-15T09:55:08Z

Ima reopen this

dependabot bot and others added 30 commits April 15, 2024 17:14

chore(deps): Update dependencies

6428e7b

chore: Fix new clippy warnings

ce5907e

feat: Add MacOS ARM64 builds

46b7742

docs: Switch to an mdbook for documentation

bb79aa6

docs: Deploy mdbook on release in the future

5008f98

chore(deps): Update dependencies

492ba4d

chore: Release 3.3.0

3519e02

docs: Fix broken links

9f53927

ci: Allow manually deploying the documentation even if it isn't a rel…

34d5b84

…ease This allows fixing bugs without making a release (if there are no breaking changes)

chore(deps): Update dependencies

7b980eb

chore(deps): Update itertools to 0.13.0

ee3f312

chore: Switch to lints table since MSRV is >1.74.0 anyway (also enabl…

d0a062e

…e some additional lints)

chore: Update dependencies

86928a7

chore(deps): Update dependencies

a8910ee

feat: Enable attest-build-provenance for releases

b034ba3

Update basics.md: Fix small typo

b8422bb

Merge pull request VorpalBlade#134 from Daniel15/patch-1

7d5d917

docs: Update basics.md: Fix small typo

dependabot bot and others added 13 commits October 20, 2025 12:33

fix(ci): Fix for mdbook

709c7ae

chore(deps): Upgrade dependencies

ab1a60f

chore(deps): Upgrade dependencies

3463910

chore: Update MSRV

b2e3c47

chore(ci): Add dependabot cooldown & change schedule.

c44fdeb

Add support for adding directories

ec12c2f

dgudim added 5 commits December 11, 2025 22:15

Add -r (--recursive) flag for and put the recursive feature behind it

7db7549

Fix tests following the latest change

7ea324a

Refactor tests to support multiple files

7e655c5

Add tests for the new recursive add functionality

7ddc0c8

Add docs for recursive add feature

9fa046f

VorpalBlade requested changes Dec 14, 2025

View reviewed changes

src/add.rs Outdated Show resolved Hide resolved

src/add/tests.rs Outdated Show resolved Hide resolved

src/add.rs Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

src/add.rs Outdated Show resolved Hide resolved

src/add.rs Outdated Show resolved Hide resolved

dgudim added 4 commits December 15, 2025 10:55

fix typo, fmt

7886d27

Improve performance of recurse_files and return error when adding a d…

bc7d110

…irectory without --recursive

Use different file contents for different test files

e3efd9d

fmt

b9d276a

dgudim closed this Dec 15, 2025

dgudim force-pushed the main branch from 5ec0e6c to b9d276a Compare December 15, 2025 09:32

dgudim mentioned this pull request Dec 15, 2025

Add -r (--recursive) flag for adding directories #289

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add support for adding directories #288

Add support for adding directories #288

Uh oh!

dgudim commented Dec 10, 2025

Uh oh!

VorpalBlade commented Dec 11, 2025

Uh oh!

dgudim commented Dec 11, 2025

Uh oh!

VorpalBlade left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgudim commented Dec 15, 2025 •

edited

Loading

Uh oh!

dgudim commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Add support for adding directories #288

Add support for adding directories #288

Uh oh!

Conversation

dgudim commented Dec 10, 2025

Uh oh!

VorpalBlade commented Dec 11, 2025

Uh oh!

dgudim commented Dec 11, 2025

Uh oh!

VorpalBlade left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dgudim commented Dec 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dgudim commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dgudim commented Dec 15, 2025 •

edited

Loading