-
Notifications
You must be signed in to change notification settings - Fork 128
Feature/totp 2fa handler #250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hey @jcoffi thanks for the contribution. I assume that the code in this PR is at least partially written by AI, in this case the OpenHands it seems. While it's great to see AI being able to write such quality code, I'm want to ask a few things first:
Additionally, based on my conversations with IBKR support, I think that TOTP is not available to all IBKR users. Not sure what the criteria is, but I'd be careful with claiming that it completely solves it - we may want to rephrase the docs regarding this. Appreciate your initiative here 🙌 |
The documentation doesn't mention TOTP being limited access. https://www.ibkrguides.com/securelogin/sls/twofactorauth.htm I'll come back to this. Just very busy for the next few days. |
…address TOTP availability concerns
Thanks for this PR. Any updates on its status? I'm quite interested given that for iOS users the Google Messages 2FA is not available from what I understand so it would be useful to have another alternative off-the-shelve. |
If you want to test it, pull the PR and try it. But eventually, it appears they are going to force everyone to use the IBKR app to MFA as the only option. They are doing it by geographic region. But if you're in with the old MFA, you can keep using it. |
@jcoffi I saw you made a few commits, but I'm not sure if you've addressed all the points I brought up in the past PR review? Is it ready for another review? @amaeckelberghe have a look at IBind and OAuth authentication for an alternative: https://github.com/Voyz/ibind/wiki/Authentication |
It's not ready yet. It will either be ready in the next few days or I'll
probably close it.
…On Fri, Jun 13, 2025 at 9:35 AM voyz ***@***.***> wrote:
*Voyz* left a comment (Voyz/ibeam#250)
<#250 (comment)>
@jcoffi <https://github.com/jcoffi> I saw you made a few commits, but I'm
not sure if you've addressed all the points I brought up in the past PR
review? Is it ready for another review?
@amaeckelberghe <https://github.com/amaeckelberghe> have a look at IBind
and OAuth authentication for an alternative:
https://github.com/Voyz/ibind/wiki/Authentication
—
Reply to this email directly, view it on GitHub
<#250 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFBU5KC7BGT3TAR47TQ5FMD3DL4WXAVCNFSM6AAAAAB3XOJMJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSNZQHEYTKNRUG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks both. @Voyz : IBind with OAuth looks to be exactly what I need, thanks for the reference (and the effort on these libraries)! @jcoffi : I had pulled your docker image and ran it. The code seems to work fuctionally on my end, however the login itself failed when I tried it ( |
Your account has to be setup for TOTP at IBKR for this to work. I may come back to this eventually. But for now, I'll close it. I just don't have time right now. |
@jcoffi No problem, thanks for the initiative nevertheless 🙌 |
Add TOTP Two-Factor Authentication Handler
Overview
This PR adds a new built-in Two-Factor Authentication handler that automatically generates Time-based One-Time Password (TOTP) codes for authentication with Interactive Brokers. This eliminates the need for manual input during the 2FA process and enables fully automated authentication workflows.
Features
Implementation Details
TotpTwoFaHandler
class that inherits fromTwoFaHandler
pyotp
library for standards-compliant TOTP code generationConfiguration
Users can enable the TOTP handler by setting:
Documentation
docs/two_factor_authentication.md
docs/totp_handler.md
Security Considerations
Testing
tests/test_totp_handler.py
Dependencies
pyotp
dependency torequirements.txt
This PR addresses the need for fully automated authentication when 2FA is enabled on IBKR accounts, making IBeam more versatile.