weird fix?

Author: Edwardius

deep_core/include/deep_core/deep_node_base.hpp

@@ -56,7 +56,7 @@ class DeepNodeBase : public rclcpp_lifecycle::LifecycleNode
   /**
    * @brief Destructor
    */
-  virtual ~DeepNodeBase() = default;
+  virtual ~DeepNodeBase();
 
 protected:
   /**

deep_core/src/deep_node_base.cpp

@@ -35,6 +35,14 @@ DeepNodeBase::DeepNodeBase(const std::string & node_name, const rclcpp::NodeOpti
     add_on_set_parameters_callback(std::bind(&DeepNodeBase::on_parameter_change, this, std::placeholders::_1));
 }
 
+DeepNodeBase::~DeepNodeBase()
+{
+  // Remove parameter callback to prevent callback invocation during destruction
+  if (parameter_callback_handle_) {
+    remove_on_set_parameters_callback(parameter_callback_handle_.get());
+  }
+}
+
 void DeepNodeBase::declare_parameters()
 {
   declare_parameter("Backend.plugin", "");