Skip to content

Bare exception handlers silently hide errors in pygame_hud_node.py #319

@jaffarkeikei

Description

@jaffarkeikei

Location: src/simulation/carla_ros_bridge/carla_pygame/carla_pygame/pygame_hud_node.py:286,292

Two bare except Exception: pass blocks silently swallow all errors during server shutdown:

try:
    self._server.serve_forever()
except Exception:  # Line 286 - no logging
    pass
finally:
    try:
        self._server.server_close()
    except Exception:  # Line 292 - no logging
        pass

Issue: Critical errors (socket issues, permission problems) are hidden, making debugging impossible.

Fix:

try:
    self._server.serve_forever()
except Exception as e:
    self.get_logger().error(f"Web server error: {e}")
finally:
    try:
        self._server.server_close()
    except Exception as e:
        self.get_logger().warn(f"Error closing server socket: {e}")

Impact: Makes debugging server crashes nearly impossible for developers.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions