Add musical key and BPM detection - #9
Open
crivote wants to merge 2 commits into
Open
Conversation
Essentia already comes with good old-school DSP algorithms for key (Krumhansl-Kessler) and tempo (Percival), so I figured the tagger might as well write those too while it's analysing the audio anyway. The overhead is tiny (~0.6s per track) because these are deterministic algorithms, not ML models. New flags: --no-key, --no-bpm (both default on) Tags written per format: FLAC/OGG/Opus → INITIALKEY, BPM MP3/AIFF/WAV → TKEY, TBPM MP4/M4A → tmpo, initialkey WMA → WM/InitialKey, WM/BeatsPerMinute APEv2 → INITIALKEY, BPM Includes 11 tests covering config, analysis, and tag writing across formats.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Essentia already comes with good old-school DSP algorithms for
key (Krumhansl-Kessler) and tempo (Percival), so I figured the
tagger might as well write those too while it's analysing the
audio anyway. The overhead is tiny (~0.6s per track) because
these are deterministic algorithms, not ML models.
New flags:
--no-key,--no-bpm(both default on)Tags written per format:
INITIALKEY,BPMTKEY,TBPMtmpo,initialkeyWM/InitialKey,WM/BeatsPerMinuteINITIALKEY,BPMIncludes 11 tests covering config, analysis, and tag writing
across formats.