Clear out unnecessary step in GHA #1274
Merged
+0
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
znichollscr
changed the title
Author
|
@ltroussellier hopefully easy and makes sense |
Author
|
Nice, the CI even shows how this fails and that the removed step isn't needed: https://github.com/WCRP-CMIP/CMIP6_CVs/actions/runs/18527226095/job/52800781285?pr=1274 |
Collaborator
yes but since the idea is to use the same code (the app) either in CI/CD or in local ! its better to switch back to the user configuration after the test. here it does not make sense since we are just testing the "test" configuration. but in local it is particularly handy ! |
Author
|
Ah ok yes but the stuff I removed doesn't do that switch does it? |
Collaborator
|
no no it is OK, thats why i merged it directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need the check if the previous job failed. If it failed, GitHub already fails the action and the logs are already there