-
Notifications
You must be signed in to change notification settings - Fork 0
Check branded variables #37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
For reference, issues this is picking up with v0.10.0 of the mapper and DR v1.2.2 Details |
wolfiex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move the requirements.txt to the scripts folder?
|
Sure. Thoughts on the question raised here: #37 (comment) ? I can do link, ID, file structure validation separately (as that can be used across all repos. Branding validation as a separate script makes sense here with any other more specific (science based) checks. I would probably also make sure the labels entries match the constructed id as part of it too. |
|
If we are running it continuously, I would make it produce a pretty md report, and have a flag to create an issue outlining the problems it finds. |
|
That's an option. Surely it's better to just run it as a validation step in CI so that we never merge anything with broken information in the first place (if you fail CI, don't merge). |
Just a demo script for now. @wolfiex should I turn this into a validation script (returns 0 if all good, 1 if not) and associated GitHub action or do you want to handle this validation another way?