Review #7 #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

juliettelavoie merged 12 commits into add-paths from add-paths-zn

Nov 6, 2025

Collaborator

znichollscr commented Nov 4, 2025

No description provided.

znichollscr added 4 commits

November 4, 2025 21:52


          CHANGELOG and docs

5ff6e79


          Update pyproject.toml

abb7503


          docstrings

a8572e8


          Test names and CHANGELOG

9e3af0a

znichollscr mentioned this pull request

Add paths and doi_level #7

Merged

3 tasks

znichollscr commented

View reviewed changes

docs/NAVIGATION.md Show resolved Hide resolved


          Update README to point to optional dependencies

a584052

znichollscr commented

View reviewed changes

pyproject.toml Show resolved Hide resolved

znichollscr commented

View reviewed changes

README.md Show resolved Hide resolved


          Add more clarity re optional dependencies

10afd33

znichollscr commented

View reviewed changes

src/cmipcite/citations.py Outdated Show resolved Hide resolved

znichollscr commented

View reviewed changes

src/cmipcite/citations.py Show resolved Hide resolved

znichollscr commented

View reviewed changes

src/cmipcite/citations.py Outdated Show resolved Hide resolved

znichollscr commented

View reviewed changes

src/cmipcite/citations.py Outdated Show resolved Hide resolved

znichollscr commented

View reviewed changes

src/cmipcite/cli/__init__.py Outdated Show resolved Hide resolved

znichollscr commented

View reviewed changes

tests/integration/test_citations_integration.py Show resolved Hide resolved

znichollscr commented

View reviewed changes

tests/integration/test_cli_integration.py Show resolved Hide resolved

znichollscr commented

View reviewed changes

tests/unit/test_citations.py Show resolved Hide resolved

znichollscr changed the title ~~Review #6~~ Review #7


          Avoid tests exploding if optional extras are not installed

ac4e4a0

juliettelavoie reviewed

View reviewed changes

docs/NAVIGATION.md Show resolved Hide resolved

src/cmipcite/cli/__init__.py Outdated Show resolved Hide resolved

src/cmipcite/cli/__init__.py Outdated Show resolved Hide resolved

src/cmipcite/citations.py Outdated Show resolved Hide resolved

pyproject.toml Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved

docs/how-to-guides/get-citations-advanced.py Show resolved Hide resolved

znichollscr added 2 commits

November 6, 2025 09:49


          Fix up bad copy paste

0a8e5f5


          Update after review

adf8b76

Collaborator Author

znichollscr commented Nov 6, 2025

@juliettelavoie I would suggest you merge this, then you can pick up the TODOs and fix them how you feel is best in #7. Let me know if you want to do something else

znichollscr added 3 commits

November 6, 2025 21:01


          Clean up README

e7dcea4


          Last cleaning up

bf1911b


          Fix docs CI

e185586

juliettelavoie merged commit 06a2f5a into add-paths

9 of 18 checks passed

znichollscr deleted the add-paths-zn branch

November 6, 2025 14:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet