Skip to content

Conversation

@Daniel-Mietchen
Copy link
Member

Fixes part of #1762

Description

We have a number of mentions of Scholia's master branch throughout the code base.

Caveats

Some of the URLs in the codebase refer to master branches of other repos, which we should perhaps check separately.

In principle, this is a breaking change, but on GitHub specifically, it should not cause any problems, as per https://github.com/github/renaming?tab=readme-ov-file .

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

Please describe the tests that you ran to verify your changes. Provide instructions, so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@Daniel-Mietchen
Copy link
Member Author

Note that the renaming (cf. issue ) has to be done before merging this.

@fnielsen fnielsen merged commit f443d08 into main Apr 6, 2025
4 checks passed
@fnielsen
Copy link
Collaborator

fnielsen commented Apr 6, 2025

Further changes:

  • The default branch has been changed GitHub setting
  • The branch in Toolforge has been updated to main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants