Skip to content

Conversation

@egonw
Copy link
Collaborator

@egonw egonw commented Apr 6, 2025

Adds missing query titles, needed for downstream use.

Description

Not all chemical aspect queries have titles:

image

This patch adds a good number of them.

Caveats

The titles are listed as comments in the SPARQL. If not well-formed, it can break running the SPARQL query.

Testing

Check if the following aspects still show content in all panels:

  • chemical
  • chemical-class
  • chemical-element

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@fnielsen
Copy link
Collaborator

fnielsen commented Apr 6, 2025

Isn't is a problem that WDQS intepretes #title as something? When we rely on the whitespace could that not go run?

@Daniel-Mietchen
Copy link
Member

@egonw Can you adjust your workflows (and thus the PR) such that there is no space between the # and the title:?
Without this space, the titles would be compatible with the way (Wikimedia's version of) Blazegraph handles titles.

@egonw
Copy link
Collaborator Author

egonw commented Apr 6, 2025

@Daniel-Mietchen, @fnielsen, I left the space deliberately, per #2304 (comment)

@fnielsen fnielsen merged commit 9d0d82c into main Apr 6, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants