Skip to content

Delete the previous content, like a 'time out' error message #2608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

egonw
Copy link
Collaborator

@egonw egonw commented Apr 12, 2025

Fixes #2560

Description

This patch resets the content of the HTML table element, e.g. the <p> element with a 'time out' error message.

Caveats

It looks that it does the right thing, e.g. for the test page in the bug report.

Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

Testing

From the bug report:

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@fnielsen
Copy link
Collaborator

I am still getting the problem.

image

@fnielsen fnielsen force-pushed the fix/reloadRemovesError branch from 0410577 to 4daa529 Compare April 12, 2025 11:29
@Daniel-Mietchen
Copy link
Member

Seems to work fine now.

@egonw
Copy link
Collaborator Author

egonw commented Apr 16, 2025

@fnielsen, can you plz tell me what you expect me to do?

@fnielsen fnielsen merged commit 4daa529 into main Apr 24, 2025
7 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After timeout and reloading a message is in the first row of the table
3 participants