Skip to content

Conversation

@egonw
Copy link
Collaborator

@egonw egonw commented Aug 23, 2025

The iframe was also supposed to use the SPARQL-level configuration, but the extracting of the config not yet implemented.

The second commit is esthetic as spaces are removed during config extraction.

Description

The first patch adds the reading for iframe of the SPARQL-level config. Not sure if I never added that, or some patch accidentally removed it. Either way, it needs to be there.

Caveats

None expected.

Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

Testing

The testing is complicated.

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@egonw egonw added the bug something wrong on our end label Aug 23, 2025
@egonw egonw force-pushed the hotfix/SPARQLconfig branch from 577d18c to 485b595 Compare August 23, 2025 19:49
@egonw egonw changed the title Two SPARQL-level config fixes SPARQL-level config hotfix Aug 23, 2025
@egonw egonw added enhancement some suggestions to improve Scholia and removed bug something wrong on our end labels Aug 23, 2025
@egonw egonw changed the title SPARQL-level config hotfix SPARQL-level config for iframes and ASK-queries Aug 23, 2025
@egonw egonw force-pushed the hotfix/SPARQLconfig branch from d78fcae to 9b98748 Compare August 23, 2025 20:40
@egonw egonw changed the title SPARQL-level config for iframes and ASK-queries SPARQL-level config for iframes Aug 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement some suggestions to improve Scholia

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants