Skip to content

Conversation

@WolfgangFahl
Copy link
Collaborator

@WolfgangFahl WolfgangFahl commented Dec 12, 2025

Fixes #2743

Description

add /backend route and template

Caveats

Please list anything which has been left out of this PR or which should be considered before this PR is accepted
Check any of the following which apply:

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
    • I have made corresponding changes to the documentation
  • This change requires new dependencies (please list)

If you make changes to the Python code

  • My code passes the tox check, I can receive warnings about tests, documentation or both

Testing

https://scholia.wikidata.dbis.rwth-aachen.de/backend

Checklist

  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have not used code from external sources without attribution
  • I have considered accessibility in my implementation
  • There are no remaining debug statements (print, console.log, ...)

@egonw egonw self-requested a review December 12, 2025 18:50
Copy link
Collaborator

@egonw egonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please have a look at the code analysis messages?

@WolfgangFahl
Copy link
Collaborator Author

Done and improved

@egonw
Copy link
Collaborator

egonw commented Dec 14, 2025

@WolfgangFahl, I note you accidentally sneaked in the port config feature from another PR: ad-freiburg@c6f32f5

And for the other two config parameters, I wrote this patch: ad-freiburg@e47078c

And this patch to fix the flake errors: ad-freiburg@0dff464

Copy link
Collaborator

@egonw egonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See most recent comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add /backend endpoint with content negotiation (JSON/HTML)

2 participants