Fixed calculation for intersections #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjaap Please have a look. Thanks! |
|
Something strange is going on with the documentation. I am trying to figure it out on my machine. Until then... |
pjaap
reviewed
May 22, 2025
|
Thank you. I am happy with these changes. Can you
|
Liameloy
force-pushed
the
dev/tetrahedronSliceFixing
branch
from
368f2d5 to
700714d
Compare
…on and plane Added new test case for specific data which caused issues beforehand
Liameloy
force-pushed
the
dev/tetrahedronSliceFixing
branch
from
700714d to
1d190ac
Compare
pjaap
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the logic which determines an intersection between tetrahedron and plane.
Added new test case for specific data which caused issues beforehand