Skip to content

Remove ForwardDiff 1 compat (again) #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pjaap
Copy link
Member

@pjaap pjaap commented Apr 8, 2025

The test environment cannot be resolved with this version, see #195 ...
Hence, it is NEVER tested and we should not include this version in the compats.

The test environment cannot be resolved with this version, 
see #195 ...
Hence, it is NEVER tested and we should not include this version in the compats.
@pjaap
Copy link
Member Author

pjaap commented Apr 8, 2025

I manually ran Pkg.test(; force_latest_compatible_version=true) with this change and it passes.

@j-fu
Copy link
Member

j-fu commented Apr 14, 2025

The relevant upstream PR is
JuliaDiff/SparseDiffTools.jl#313

It is not clear if this will be fixed as people move on to do sparsity detection via DifferentiationInterface.jl. (discussed on the Julia slack). I think it is time then to replace that dependency...

@gdalle
Copy link

gdalle commented Apr 14, 2025

It had been prophesized, and now the time has come ;)
#109

@j-fu
Copy link
Member

j-fu commented Apr 15, 2025

Well, but: JuliaDiff/DifferentiationInterface.jl#774
Though I think I can tolerate the regression (which does not affect core functionality), there seems to be someting that SparseDiffTools is doing better (or I miss some options to tune things).

@gdalle
Copy link

gdalle commented Apr 15, 2025

Taking a look!

@j-fu
Copy link
Member

j-fu commented Apr 16, 2025

#203 solves this with respect to direct dependencies as this gets rid of SparseDiffTools. Test dependencies still need to evolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants