Remove the marker attribute from explainer#94
Conversation
marker attribute from explainer
Co-authored-by: Barry Pollard <barrypollard@google.com>
Removed examples of named processing instructions and multiple markers from the patching section. Updated HTML syntax for template usage.
| <section marker="gallery"> | ||
| <section> | ||
| Actual gallery content | ||
| </section> |
There was a problem hiding this comment.
Somewhat beyond this change, but a question on how this works with white space?
If we have:
<section>
<?start name="gallery">Loading...<?end>
</section>
<template for="gallery">
Actual gallery content
</template>Then this actually becomes this, I think, as there is white space before <?start name="gallery">, after <?end> but also in the template.
<section>
Actual gallery content
</section>Does this matter? Should we use below instead (which also matches the <?start name="gallery">Loading...<?end> it's replacing better).
<template for="gallery">Actual gallery content</template>Or should whitespace be auto collapses? Or should we have Jinja style strip operators/ attributes?
<template for="gallery" ->
Actual gallery content
</template>Or
<template for="gallery" strip="both">
Actual gallery content
</template>There was a problem hiding this comment.
yea your observations are correct, but only matter if you use raw text content instead of elements so in most cases wouldn't have a real effect
There was a problem hiding this comment.
It might be worth adding a line such as:
Note: These examples ignore extra white space introduced for simplicity and readability. Developers may need to consider such white space issues in certain circumstances.
WDYT?
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
SHA: f7b6ab0 Reason: push, by noamr Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
No description provided.