Skip to content

Remove the marker attribute from explainer#94

Merged
noamr merged 10 commits into
mainfrom
noamr-patch-8
Mar 18, 2026
Merged

Remove the marker attribute from explainer#94
noamr merged 10 commits into
mainfrom
noamr-patch-8

Conversation

@noamr

@noamr noamr commented Mar 18, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@noamr
noamr requested review from foolip and tunetheweb March 18, 2026 12:52
@noamr noamr changed the title Refactor patching instructions in HTML examples Remove the marker attribute from explainer Mar 18, 2026
Comment thread patching-explainer.md Outdated
Comment thread patching-explainer.md Outdated
Comment thread patching-explainer.md
Comment thread patching-explainer.md Outdated
Comment thread patching-explainer.md
noamr and others added 2 commits March 18, 2026 13:08
Co-authored-by: Barry Pollard <barrypollard@google.com>
Removed examples of named processing instructions and multiple markers from the patching section. Updated HTML syntax for template usage.
@noamr
noamr requested a review from tunetheweb March 18, 2026 13:59
Comment thread patching-explainer.md
<section marker="gallery">
<section>
Actual gallery content
</section>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhat beyond this change, but a question on how this works with white space?

If we have:

<section>
  <?start name="gallery">Loading...<?end>
</section>

<template for="gallery">
  Actual gallery content
</template>

Then this actually becomes this, I think, as there is white space before <?start name="gallery">, after <?end> but also in the template.

<section>

  Actual gallery content

</section>

Does this matter? Should we use below instead (which also matches the <?start name="gallery">Loading...<?end> it's replacing better).

<template for="gallery">Actual gallery content</template>

Or should whitespace be auto collapses? Or should we have Jinja style strip operators/ attributes?

<template for="gallery" ->
  Actual gallery content
</template>

Or

<template for="gallery" strip="both">
  Actual gallery content
</template>

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea your observations are correct, but only matter if you use raw text content instead of elements so in most cases wouldn't have a real effect

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth adding a line such as:

Note: These examples ignore extra white space introduced for simplicity and readability. Developers may need to consider such white space issues in certain circumstances.

WDYT?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Comment thread patching-explainer.md Outdated
Comment thread patching-explainer.md Outdated
Comment thread patching-explainer.md Outdated
Comment thread patching-explainer.md Outdated
Comment thread patching-explainer.md Outdated
noamr and others added 6 commits March 18, 2026 15:02
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
Co-authored-by: Barry Pollard <barrypollard@google.com>
@noamr
noamr requested a review from tunetheweb March 18, 2026 15:11
@noamr
noamr merged commit f7b6ab0 into main Mar 18, 2026
2 checks passed
github-actions Bot added a commit that referenced this pull request Mar 18, 2026
SHA: f7b6ab0
Reason: push, by noamr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants