-
Notifications
You must be signed in to change notification settings - Fork 48
Enable get() in fenced frames with network access revoked. #220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d4f7157
Spec: Enable get() in fenced frames with network access revoked.
VergeA df5f480
Merge pull request #1 from WICG/main
VergeA 365970a
Add permissions policy section.
VergeA 2695c7f
Fixes
VergeA d89e086
Reorder addModule clause
VergeA 19b3e89
More complete algo, doc updates
VergeA 26b3fcb
Fix permissions policy build issue.
VergeA 51c71fe
Fix missing divs.
VergeA 86d8585
Fix preferences error and documentation sections.
VergeA e786201
Fix promise rejections
VergeA 561c8f8
Merge branch 'main' into read2
VergeA f9be64f
Fix typo
VergeA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the "fully revoked" algorithm defined? I don't see it in this PR or in the existing spec.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's defined as a standalone algorithm in the Fenced Frames spec: https://wicg.github.io/fenced-frame/#gating-methods-on-network-revocation
I assumed since the build succeeds that the reference is being linked properly. Is there anything else I should do to clarify where this algo comes from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I was looking in the shared storage spec!