Skip to content

fix: Ensure user-provided onclick event in Link component doesn't override internal onclick #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2025
Merged

fix: Ensure user-provided onclick event in Link component doesn't override internal onclick #52

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67667b4
fix: Ensure user-provided onclick event in Link component doesn't ove…
webJose Sep 7, 2025
7ac1b2a
feat: Move calling order around to enable navigation cancellation
webJose Sep 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/Link/Link.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@
prependBasePath,
preserveQuery,
children,
onclick: incomingOnclick,
...restProps
}: Props = $props();
Expand All @@ -101,10 +102,11 @@
)
);
function handleClick(event: MouseEvent) {
function handleClick(event: MouseEvent & { currentTarget: EventTarget & HTMLAnchorElement }) {
event.preventDefault();
const newState = calculateState(resolvedHash, typeof state === 'function' ? state() : state);
location.goTo(calcHref, { state: newState, replace: calcReplace });
incomingOnclick?.(event);
}
function styleString() {
Expand Down