fix(Link): Make explicit replacement of empty string for current URL to support Sveltekit #99
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to support Sveltekit The problem is Sveltekit, that loses the hash tags when doing shallow routing. Issue logged: sveltejs/kit#14648 Since I have no idea if this will be fixed fast enough, this is the workaround.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements a workaround for a SvelteKit issue where hash tags are lost during shallow routing by explicitly handling empty string hrefs in the Link component.
- Adds conditional logic to use the current URL when href is an empty string
- Modifies the calcHref derived value to bypass calculateHref function for empty hrefs
- Provides immediate workaround for SvelteKit hash tag preservation issue
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem is Sveltekit, that loses the hash tags when doing shallow routing.
Issue logged: sveltejs/kit#14648
Since I have no idea if this will be fixed fast enough, this is the workaround.