fix: Empty props on unmount #181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Not sure if you are accepting PR-s for single-spa-related projects any more, but I'll just use my fork if not.
I'm using
single-spa+single-spa-layout+vite-plugin-single-spa+@wjfe/single-spa-svelte.I have a single microfrontend that is mounted to the page under two subroutes, with different props passed in each case.
Let's say the microfrontend
"mfe1"is mounted as these variants:If I follow these steps:
Then Variant B is passed props like this:
Getting the
fooprop (only defined for Variant A) passed to Variant B is not expected.I added a test that fails before the fix, and passes after the fix.