Skip to content

fake PR for code review#1

Open
ndebruin wants to merge 11 commits intomainfrom
history-merge
Open

fake PR for code review#1
ndebruin wants to merge 11 commits intomainfrom
history-merge

Conversation

@ndebruin
Copy link

No description provided.

#include "TxByteBuffer.h"
#include "RxBuffer.h"

#define BYTE_BUFFER_SIZE 1024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make buffers work

#include <Arduino.h>

template <size_t SIZE>
class TxByteBuffer {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite

uint8_t length; // 240 < 255
};

class RxBuffer
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rewrite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants