Skip to content

L25~L27-conflictsSolved-reviewTest#38

Open
hattiepwvi wants to merge 2 commits intoWTFAcademy:mainfrom
hattiepwvi:main
Open

L25~L27-conflictsSolved-reviewTest#38
hattiepwvi wants to merge 2 commits intoWTFAcademy:mainfrom
hattiepwvi:main

Conversation

@hattiepwvi
Copy link
Copy Markdown
Contributor

L25~L27-conflictsSolved-reviewTest

L25: immutable, self, empty(bool)==False, pulic, expression
L26: from implements, 0x150b7a02, immutable, self, token_id, expression, return empty(xxx)
L27: ERC1155MetadataURI, return empty(xxx), immutable, self, expression

@hattiepwvi
Copy link
Copy Markdown
Contributor Author

hattiepwvi commented Apr 7, 2024

L28: Native fractionalization, return empty(xxx), expression, url(erc404.vy -> TOKEN404.vy)

all _check_on_xxx
e.g.

@internal
def _check_on_erc721_received(_from: address, _to: address, _token_id: uint256, _data: Bytes[1024]) -> bool:
if (_to.is_contract):
return_value: bytes4 = ERC721Receiver(_to).onERC721Received(msg.sender, _from, _token_id, _data)
assert return_value == method_id("onERC721Received(address,address,uint256,bytes)", output_type=bytes4)
return True
else:
return True

all tested

@hattiepwvi
Copy link
Copy Markdown
Contributor Author

L28. ----- wait a moment pl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant