-
Notifications
You must be signed in to change notification settings - Fork 52
Wui 242 component stepper responsive #3094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: chore-belonging
Are you sure you want to change the base?
Wui 242 component stepper responsive #3094
Conversation
c672be2 to
dbc1131
Compare
|
Could you please rebase @jonathan-herbault? thanks |
0a00500 to
f05d37b
Compare
@cnairi sounds good now. And thx for the tips ! |
5148c04 to
723dd14
Compare
f05d37b to
1f674c5
Compare
Isaacmaamouche
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think using the intersection observer to check for the first step item and its container left boundary (same for last item and right boundary) could be better for performance but that could mean a complete rework of what you did.
I can try giving it a shot in the coming week. For now, this is still great!
| &.fade-left::before { | ||
| content: ''; | ||
| position: absolute; | ||
| left: 0; | ||
| top: 0; | ||
| bottom: 0; | ||
| width: 70px; | ||
| background: linear-gradient( | ||
| to right, | ||
| var(--components-colors-stepper-color-background), | ||
| transparent | ||
| ); | ||
| pointer-events: none; | ||
| z-index: 1; | ||
| } | ||
|
|
||
| &.fade-right::after { | ||
| content: ''; | ||
| position: absolute; | ||
| right: 0; | ||
| top: 0; | ||
| bottom: 0; | ||
| width: 70px; | ||
| background: linear-gradient( | ||
| to left, | ||
| var(--components-colors-stepper-color-background), | ||
| transparent | ||
| ); | ||
| pointer-events: none; | ||
| z-index: 1; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can have a basic class for
content: '';
position: absolute;
top: 0;
bottom: 0;
width: 70px;
pointer-events: none;
z-index: 1;
Then have a class for each with
right: 0;
background: linear-gradient(
to left,
var(--components-colors-stepper-color-background),
transparent
);
| overflow: hidden; | ||
| } | ||
|
|
||
| .root { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe root and wrapper can be switch name
| -ms-overflow-style: none; | ||
| scrollbar-width: none; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to keep scrollbar, even if is not beautiful
DESCRIPTION
This Pr aims to update de stepper to be more responsive and not broken on little screen.
The different main changes are (https://linear.app/wttj/issue/WUI-242/component-or-stepper) :
HOW TO TEST
Find the Stepper component.
Check that previous exemples are not broken.
A new exemple
responsivehas been added to demonstrate (and help to test) the responsive of the Stepper.SCREENSHOTS / SCREEN RECORDINGS
Scroll Right fade:
Both scroll fade:

Scroll left fade :

ANIMATION:
https://github.com/user-attachments/assets/910eb84f-55b3-46c6-8781-09af7b5fcb1a
COMPATIBILITY
QA